Skip to content

Bump deps of samples#4436

Closed
compulim wants to merge 9 commits intomicrosoft:mainfrom
compulim:bump-samples
Closed

Bump deps of samples#4436
compulim wants to merge 9 commits intomicrosoft:mainfrom
compulim:bump-samples

Conversation

@compulim
Copy link
Copy Markdown
Contributor

@compulim compulim commented Sep 28, 2022

Related to #4415.

Changelog Entry

Samples

Description

Bumping dependencies used by samples.

Design

Added a new NPM script bump:samples to recursively bump dependencies used by samples.

  • prebump script will remove all dependencies which are local peers, listed in localPeers field
    • When bumping dependencies, any Lerna-managed local peers must be removed
  • postbump script will add back all local peer dependencies using version 0.0.0-0
    • Currently, it is not super trivial to remember the previous version number. As we always use 0.0.0-0, it's okay for now
  • Both scripts can be run independently multiple times without cascading effects

We should add prebump and postbump to production package.json later.

Sample output of npm run bump:samples

image

Specific Changes

  • Added NPM script bump:samples to root package.json
  • Updated NPM script bump on all samples
  • I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

@compulim compulim added the release Release checklist label Sep 28, 2022
@compulim compulim marked this pull request as ready for review September 30, 2022 20:24
@compulim compulim added this to the release-4.15.5 milestone Oct 29, 2022
@compulim
Copy link
Copy Markdown
Contributor Author

compulim commented Dec 1, 2022

Closed in favor of #4534. We will run npm run bump:samples later.

@compulim compulim closed this Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release Release checklist

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant