Bump deps of samples#4436
Closed
compulim wants to merge 9 commits intomicrosoft:mainfrom
Closed
Conversation
806c196 to
9b0cf09
Compare
Contributor
Author
|
Closed in favor of #4534. We will run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Samples
Description
Bumping dependencies used by samples.
Design
Added a new NPM script
bump:samplesto recursively bump dependencies used by samples.prebumpscript will remove all dependencies which are local peers, listed inlocalPeersfieldpostbumpscript will add back all local peer dependencies using version0.0.0-00.0.0-0, it's okay for nowWe should add
prebumpandpostbumpto productionpackage.jsonlater.Sample output of
npm run bump:samplesSpecific Changes
bump:samplesto rootpackage.jsonbumpon all samplesI have added tests and executed them locallyCHANGELOG.mdI have updated documentationReview Checklist
Accessibility reviewed (tab order, content readability, alt text, color contrast)Browser and platform compatibilities reviewedCSS styles reviewed (minimal rules, noz-index)Internationalization reviewed (strings, unit formatting)package.jsonandpackage-lock.jsonreviewedSecurity reviewed (no data URIs, check for nonce leak)Tests reviewed (coverage, legitimacy)